[MISC] 8.4 - Bump rolling-ops charmlib to v1#255
Open
sinclert-canonical wants to merge 5 commits into8.4/edgefrom
Open
[MISC] 8.4 - Bump rolling-ops charmlib to v1#255sinclert-canonical wants to merge 5 commits into8.4/edgefrom
sinclert-canonical wants to merge 5 commits into8.4/edgefrom
Conversation
sinclert-canonical
added
the
enhancement
github-actions
Bot
added
the
Libraries: Out of sync
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
sinclert-canonical
force-pushed
the
sinclert/8.4/rolling-ops-v1
branch
from
d07d31f to
8fe751d
Compare
sinclert-canonical
force-pushed
the
sinclert/8.4/rolling-ops-v1
branch
from
60ba1c7 to
40c7dd3
Compare
paulomach
approved these changes
Apr 23, 2026
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
Ok - but we wait on the merge
sinclert-canonical
force-pushed
the
sinclert/8.4/rolling-ops-v1
branch
from
40c7dd3 to
a21b6a0
Compare
sinclert-canonical
force-pushed
the
sinclert/8.4/rolling-ops-v1
branch
from
a21b6a0 to
32b773e
Compare
sinclert-canonical
force-pushed
the
sinclert/8.4/rolling-ops-v1
branch
from
32b773e to
97c3b7f
Compare
Contributor
Author
|
🗞️ This PR has been updated to validate its compatibility with curren rolling-ops v1 Python package efforts:
Up to @paulomach how much do we want to wait for canonical/charmlibs#445 to get merged. |
Contributor
|
I'd also be in favour of waiting for canonical/charmlibs#445 |
astrojuanlu
approved these changes
Apr 24, 2026
Contributor
astrojuanlu
left a comment
astrojuanlu
left a comment
There was a problem hiding this comment.
Other than that, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the
rolling-opscharmlib to v1.These changes are necessary to be able to react on multiple callbacks, thanks to the FIFO queue that v1 introduced. These callbacks will be used not only for restarting the workload (current use-case), but also to restart group replication whenever TLS gets enable / disable.
Compatibility
This PR does change the peers relation name, which makes it incompatible with MySQL 8.4 deployments.
Depends on canonical/charmlibs#419.