Conversation
878e3e3 to
11ac340
Compare
|
Upgrade tests failing with The rest seem just flaky or slow, I'll restart them a few more times. |
paulomach
left a comment
There was a problem hiding this comment.
Nothing polemic, better optic
sinclert-canonical
left a comment
There was a problem hiding this comment.
I see we are not fully decoupling the generation of the CA chain location from the creation of the backup temporal directory, as discussed online. I assume there is a good reason for this, because last time we spoke we were on the same page about splitting them.
The proposed approach is alright to me.
The same comments left for the K8s implementation, also apply to the VM one.
Yes. On one hand, the CA chain file creation is already split: And on the other hand, I was misguided - I thought the CA chain file creation was the exception, but it wasn't: executing the wrapper as |
|
Tests were passing before, so I'm merging and rebasing #257. |
Issue
Ended up accumulating lots of cleanups in #87, so I decided to send a separate pull request:
Note: This does not include adapting to the new backup helpers, because it turns out those need a writable temporary directory. Instead of introducing some interim hack, I prefer to do both adaptation + separation of storage in a single PR.
Main changes:
tls_ca_chaintype object-storage-integrator#170)pyproject.tomlbut also some actual typing improvementsSolution
Checklist