Conversation
erinecon
left a comment
erinecon
left a comment
There was a problem hiding this comment.
Thank you so much for creating landing pages 🎉 some initial comments from me
There was a problem hiding this comment.
I don't like the fact that there's an orphan page under a section, but since I'm interested in writing more documentation about using Terraform modules, I think we should leave this page alone and add onto the developer section in the near future :)
| ## Guide for developers | ||
|
|
||
| Learn the guidelines and best practices before contributing to the | ||
| backup charm project. |
There was a problem hiding this comment.
| backup charm project. | |
| OpenCTI charms project. |
| * [Integrations](integrations.md) | ||
| * [Observability](observability.md) | ||
|
|
||
| ## Charm architecture and designs | ||
|
|
||
| Components and dependencies within the OpenCTI charms, along with the | ||
| architecture decisions made during charm creation. | ||
|
|
||
| * [Charm architecture](charm-architecture.md) |
There was a problem hiding this comment.
To avoid having an orphan file under this section, I recommend we regroup the integrations.md page:
| * [Integrations](integrations.md) | |
| * [Observability](observability.md) | |
| ## Charm architecture and designs | |
| Components and dependencies within the OpenCTI charms, along with the | |
| architecture decisions made during charm creation. | |
| * [Charm architecture](charm-architecture.md) | |
| * [Observability](observability.md) | |
| ## Charm architecture and designs | |
| Components and dependencies within the OpenCTI charms, | |
| architecture decisions made during charm creation, and how | |
| the charms connect to the broader Juju ecosystem. | |
| * [Charm architecture](charm-architecture.md) | |
| * [Integrations](integrations.md) |
| actions. Understanding the overall charm architecture provides the | ||
| structural context needed to see how those settings and actions interact | ||
| at runtime. |
There was a problem hiding this comment.
Since you've grouped the architecture page into the other section, I think we should remove this sentence about charm architecture from under the "Charm configuration and operations" section. You could move it under the charm architecture section -- I trust your judgement :)
2 participants
Applicable spec:
Overview
Add landing pages to OpenCTI documents
Rationale
Juju Events Changes
Module Changes
Add landing pages to OpenCTI documents.
Library Changes
Checklist
urgent,trivial,complex)