prepare-device: implement reference prepare-device hook#111
Open
tonyespy wants to merge 1 commit intocanonical:20from
Open
prepare-device: implement reference prepare-device hook#111tonyespy wants to merge 1 commit intocanonical:20from
tonyespy wants to merge 1 commit intocanonical:20from
Conversation
Fixes: canonical#110 Signed-off-by: Tony Espy <espy@jam-arm64.localdomain>
tonyespy
force-pushed
the
add-prepare-device-hook
branch
from
c5b1b37 to
eea8bea
Compare
Member
|
Tbh I'm a bit reluctant to backport this sort of changes, as this is just for reference and it is in the more modern gadgets. And new projects should be based on those, not on 20. |
xnox
approved these changes
Mar 25, 2024
Contributor
xnox
left a comment
xnox
left a comment
There was a problem hiding this comment.
Given how confusing all of this is, I'd rather have this here, than not.
Contributor
|
also can we just make MODEL_APIKEY somehow snapctl set'able? such that verbantim pc gadget can just be used with serial vaults without need to maintain a forked gadged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapcraft.io points to this as the "reference" implementation of the amd64 gadget. However, no prepare-device hook makes this an incomplete reference, especially for private store operators
The proposed prepare-device hook would not change the behavior of the default PC gadget. However, it could then be forked and trivially modified to use for private store authentication.
This PR is just a backport of the reference hook added to the
22and24branches.