Skip to content

[DPE-9205] Update endpoint in pre-refresh check#1378

Open
dragomirp wants to merge 2 commits into16/edgefrom
update-rels-on-prerefresh
Open

[DPE-9205] Update endpoint in pre-refresh check#1378
dragomirp wants to merge 2 commits into16/edgefrom
update-rels-on-prerefresh

Conversation

@dragomirp
Copy link
Copy Markdown
Contributor

@dragomirp dragomirp commented Jan 15, 2026

Update the relation endpoints when switching over, so that clients don't have to wait for topology observer to update the relation.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp dragomirp added the bug Something isn't working as expected label Jan 15, 2026
@github-actions github-actions Bot added the Libraries: Out of sync The charm libs used are out-of-sync label Jan 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.52%. Comparing base (ed4a41b) to head (7caaf95).

Files with missing lines Patch % Lines
src/charm.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1378      +/-   ##
===========================================
- Coverage    70.53%   70.52%   -0.02%     
===========================================
  Files           16       16              
  Lines         4297     4298       +1     
  Branches       691      691              
===========================================
  Hits          3031     3031              
- Misses        1055     1056       +1     
  Partials       211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taurus-forever
Copy link
Copy Markdown
Contributor

That actually fixes pre-refresh-check (as always executed on /leader).
The action promote-to-primary is also works faster (due to topology observer events). Still it takes ~20 seconds.
@dragomirp merging?

BTW, does all CI tests passed with the first try?

@dragomirp dragomirp marked this pull request as ready for review January 19, 2026 11:16
@dragomirp
Copy link
Copy Markdown
Contributor Author

That actually fixes pre-refresh-check (as always executed on /leader). The action promote-to-primary is also works faster (due to topology observer events). Still it takes ~20 seconds. @dragomirp merging?

For promote-to-primary, we can most probably update the unit peer data. That should trigger an event on the Juju leader and update the endpoints. Should I try as part of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants