rtnetlink: ensure tests pass when using noble's version of pyroute2#164
Merged
ogayot merged 2 commits intocanonical:mainfrom Feb 2, 2026
Merged
rtnetlink: ensure tests pass when using noble's version of pyroute2#164ogayot merged 2 commits intocanonical:mainfrom
ogayot merged 2 commits intocanonical:mainfrom
Conversation
Chris-Peterson444
approved these changes
Jan 28, 2026
ogayot
force-pushed
the
pyroute2-0.7.11-test
branch
2 times, most recently
from
41efbba to
ef84575
Compare
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
pyroute2-0.7.11-test
branch
from
ef84575 to
23f50bb
Compare
dbungert
approved these changes
Feb 2, 2026
| # We need to patch the class, not the instance for some reason. | ||
| with mock.patch.object(IPRoute, "fileno", return_value=42): | ||
| version_str = importlib.metadata.version("pyroute2") | ||
| pyroute2_version = tuple([int(x) for x in version_str.split(".")]) |
Member
There was a problem hiding this comment.
Suggested change
| pyroute2_version = tuple([int(x) for x in version_str.split(".")]) | |
| pyroute2_version = tuple(int(x) for x in version_str.split(".")) |
Just learned that we can do tuple comprehension like this, without the intermediate list
Member
Author
There was a problem hiding this comment.
TIL, thanks for the suggestion!
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
pyroute2-0.7.11-test
branch
from
23f50bb to
b080bcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rtnetlink unit tests are running fine when using tox (i.e., with modern pyroute2 0.9.x), but running them using pyroute2 from noble/core24 fails in multiple test functions.
It isn't the pyroute2 module itself that is too old, but the mock classes.