fix(oracle): update condition for setting public ips#493
Merged
uhryniuk merged 1 commit intocanonical:mainfrom Nov 26, 2025
Merged
fix(oracle): update condition for setting public ips#493uhryniuk merged 1 commit intocanonical:mainfrom
uhryniuk merged 1 commit intocanonical:mainfrom
Conversation
The Oracle provider in pycloudlib will attempt to assign a public IP to the instance. However, the current implementation assumed that the subnet was always public but this may not be true. To remedy this, we explicitly add checks that the subnet allows public ips to be assigned, then we set that configuration in the vnic details"
uhryniuk
force-pushed
the
fix/oracle/conditional-public-ip
branch
from
579fcb0 to
db44331
Compare
Gisaldjo
approved these changes
Nov 26, 2025
uhryniuk
force-pushed
the
fix/oracle/conditional-public-ip
branch
from
cc98893 to
db44331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Oracle provider in pycloudlib will attempt to assign a public IP to the instance. However, the current implementation assumed that the subnet was always public but this may not be true.
To remedy this, we explicitly add checks that the subnet allows public ips to be assigned, then we set that configuration in the vnic details"
Additional Context and Relevant Issues
On other internal tooling, we began to see errors where when trying to launch instances that had a private subnet, they would fail with an API error.
Test Steps
Launch an instance specifying a public subnet and ensure that IPs for ipv6 and ipv4 are both assigned.
Launch an instance specifying a private subnet and ensure no ips are attempted to even be allocated, as this would cause the above exception to be thrown.