fix(tooltip): fix wrong initial and focus tooltip positions in followMouse mode#1278
fix(tooltip): fix wrong initial and focus tooltip positions in followMouse mode#1278bmichalowski wants to merge 2 commits intocanonical:mainfrom
Conversation
|
bmichalowski is not a collaborator of the repo |
|
@canonical/react-library-maintainers please take a look at the proposed changes |
edlerd
left a comment
There was a problem hiding this comment.
Thank you for the contribution. This is an improved handling of the follow mouse mode indeed!
Some small nitpicks on formatting below, then this LGTM to merge.
|
Please stash all your commits with the formatting changes into one for a clean history. |
|
Also, please rebase on the main branch to pull in recent updates. |
|
@bmichalowski Are you interested in continuing working on the issue? |
fix(tooltip): listen to mousemove event also for closed tooltip test(tooltip): add visibility tests for followMouse case test(tooltip): remove unnecessary followMouse flag from test fix(tooltip): pr changes
ba362c1 to
707cb88
Compare
|
@bartaz Yes, I'd be happy to finish it. However, I need a helping hand with Percey. Visually, nothing changes, so I think it should be marked as non-required. However, it starts and crashes during execution. |
Done
The tooltip did not handle the initial position correctly in followMouse mode.
There was also an issue with listening to mouse move events only when the tooltip was open.
QA
Pinging @canonical/react-library-maintainers for a review.
QA steps
Bug 1: Tooltip is not visible on keyboard focus in followMouse mode
Bug 2: Tooltip appears at previous cursor location instead of current
Percy steps
No visual changes expected