Open
Conversation
…ropriate value, as it used to always allocate max memory
Dav3-K3rn
reviewed
Oct 21, 2025
| { | ||
| if (len_bytes == 0){ | ||
| die("len_bytes can not be 0"); | ||
| } |
There was a problem hiding this comment.
Good use of validation to check len_bytes is not zero. This prevents division by zero and catches empty filter files.
| } | ||
| if (len_bytes % sizeof(struct sock_filter) != 0){ | ||
| die("filter length %u is not a multiple of instruction size %u", len_bytes, sizeof(struct sock_filter)); | ||
| } |
There was a problem hiding this comment.
The modulo operator % can be expensive. Consider using bitwise operations if sizeof(struct sock_filter) is a power of 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added checks for len_bytes value
changed allocation of memory to the appropriate value, as it always allocated max allowed memory.