Various Improvements and Feedback (DevSkiller - Reuben Roessler)#14
Open
rroessler wants to merge 1 commit intocanonical:mainfrom
Open
Various Improvements and Feedback (DevSkiller - Reuben Roessler)#14rroessler wants to merge 1 commit intocanonical:mainfrom
rroessler wants to merge 1 commit intocanonical:mainfrom
Conversation
- Fixed styling to be consistent (recommend adding a style-guide in future) - Changed "die" to "sc_show_error_and_die" to be non-ambiguous. - Added appropriate "free" and "fclose" handling for the library. - Added "unrestricted" check for headers as they can have unsupported values. - Added documentation comments for the "seccomp.h" include.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the following improvements:
Additionally, some feedback that I have regarding this library includes:
freeorfcloseitems). It would be prudent to simplify this process into the exposed methods so that all allocated data or opened files can be safely removed in the event of failures. Eg: Use an opaque pointer for necessary operations.