Skip to content

chore(deps): relax jsonschema constraint to >=4.23,<5. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niemeyer merged 3 commits into from
Mar 25, 2026
Merged

chore(deps): relax jsonschema constraint to >=4.23,<5. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e37d3c
chore(deps): relax jsonschema constraint to >=4.23,<5.
Chiori-Ndukwe Mar 24, 2026
41e4e05
chore(deps): upgraded python to 3.9 due to compatibility issues with …
Chiori-Ndukwe Mar 24, 2026
2c8e562
chore(deps-dev): modernize testing and linting tools
Chiori-Ndukwe Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,37 @@ classifiers = [
]

[tool.poetry.dependencies]
python = "^3.8"
python = "^3.9"
# Pinning jsonschema because its dependencies introduced
# a dependency of rustc, which we don't want to have installed
# in charms that use SDI
# For more information go to canonical/bundle-kubeflow/issues/648
# For more reference go to:
# https://github.com/python-jsonschema/jsonschema/issues/1117
# https://github.com/python-jsonschema/jsonschema/issues/1114
jsonschema = ">4, <4.18"
#
# Current state (2024–2025):
# jsonschema >= 4.18 ships pure-Python wheels (py3-none-any)
# rpds-py provides pre-built wheels for common platforms (manylinux, macOS, Windows, ARM)
# Rust is only required when building rpds-py from source
#
# NOTE:
# While rpds-py ships prebuilt wheels, Rust may still be required if pip falls
# back to source builds (e.g., unsupported platforms, outdated pip,or
# --no-binary usage). Build environments SHOULD prefer
# wheels (e.g., --only-binary=:all:) to avoid reintroducing this dependency.
#
# The constraint is therefore relaxed to align with current ecosystem behavior
# and downstream requirements (e.g., litellm >= 1.82.3 requires jsonschema >= 4.23),
# while preserving API stability (<5.0.0).
jsonschema = ">4.23, <5.0"
ops = "*"
pyyaml = "*"
requests = "*"

[tool.poetry.dev-dependencies]
black = "^23.1"
flake8 = "^3.8"
flake8 = "^7.0"
flake8-builtins = "^1.5.3"
flake8-copyright = "^0.2.4"
flake8-docstrings = "^1.6.0"
Expand All @@ -46,7 +61,7 @@ isort = "^5.9"
mdformat = "^0.7"
mdformat-gfm = "^0.3"
mypy = "^1.4"
pytest = "^6.2"
pytest = "^8.0"
pytest-mock = "^3.6"
types-jsonschema = "^3.2"
types-pyyaml = "^5.4"
Expand Down
26 changes: 18 additions & 8 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,25 @@ max-line-length = 100
max-doc-length = 100
max-complexity = 11
docstring-convention = google

# IGNORE RULES EXPLANATION:
# W503: line break before binary operator
# W504: line break after binary operator
# D100: module-level docstring
# D104: package-level docstring
# D105: magic method docstring
# D107: __init__ docstring
# D401: "imperative mood" in docstrings
# N818: exceptions must have Error suffix
ignore =
W503, # line break before binary operator
W504, # line break after binary operator
D100, # module-level docstring
D104, # package-level docstring
D105, # magic method docstring
D107, # __init__ docstring
D401, # "imperative mood" in docstrings
N818 # exceptions must have Error suffix
W503,
W504,
D100,
D104,
D105,
D107,
D401,
N818
builtins = FileNotFoundError
exclude =
juju/client/_*
Expand Down
Loading