forked from gnuoy/snap-openstack
-
Notifications
You must be signed in to change notification settings - Fork 35
feat: generate charm dellpowervault #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmad-can
wants to merge
3
commits into
canonical:main
Choose a base branch
from
ahmad-can:feature/generate-dellpowervault-charm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
sunbeam-python/sunbeam/storage/backends/dellpowervault/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # SPDX-FileCopyrightText: 2026 - Canonical Ltd | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Dell PowerVault backend for Sunbeam storage.""" |
97 changes: 97 additions & 0 deletions
97
sunbeam-python/sunbeam/storage/backends/dellpowervault/backend.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| # SPDX-FileCopyrightText: 2026 - Canonical Ltd | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Dell PowerVault backend implementation using base step classes.""" | ||
|
|
||
| import logging | ||
| from enum import StrEnum | ||
| from typing import Annotated | ||
|
|
||
| from pydantic import Field | ||
| from rich.console import Console | ||
|
|
||
| from sunbeam.core.manifest import StorageBackendConfig | ||
| from sunbeam.storage.base import StorageBackendBase | ||
|
|
||
| LOG = logging.getLogger(__name__) | ||
| console = Console() | ||
|
|
||
|
|
||
| class Protocol(StrEnum): | ||
| """Enumeration of valid protocol types.""" | ||
|
|
||
| FC = "fc" | ||
| ISCSI = "iscsi" | ||
|
|
||
|
|
||
| class DellPowerVaultConfig(StorageBackendConfig): | ||
| """Configuration model for Dell PowerVault backend. | ||
|
|
||
| This model includes ALL configuration options for the backend. | ||
| Additional configuration can be managed dynamically through the charm. | ||
| """ | ||
|
|
||
| # Mandatory connection parameters | ||
| san_ip: Annotated[ | ||
| str, Field(description="Storage array management IP address or hostname") | ||
| ] | ||
|
|
||
| protocol: Annotated[ | ||
| Protocol, | ||
| Field(description="Protocol selector: fc, iscsi."), | ||
| ] | ||
|
|
||
| # Optional backend configuration | ||
| driver_ssl_cert: Annotated[ | ||
| str | None, | ||
| Field( | ||
| description="PEM-encoded SSL certificate for HTTPS connections to the storage array." # noqa: E501 | ||
| ), | ||
| ] = None | ||
|
|
||
| pvme_pool_name: Annotated[ | ||
| str | None, | ||
| Field(description="Pool or Vdisk name to use for volume creation."), | ||
| ] = None | ||
|
|
||
| pvme_iscsi_ips: Annotated[ | ||
| str | None, | ||
| Field(description="List of comma-separated target iSCSI IP addresses."), | ||
| ] = None | ||
|
|
||
|
|
||
| class DellPowerVaultBackend(StorageBackendBase): | ||
| """Dell PowerVault backend implementation.""" | ||
|
|
||
| backend_type = "dellpowervault" | ||
| display_name = "Dell PowerVault" | ||
| generally_available = False | ||
|
|
||
| @property | ||
| def charm_name(self) -> str: | ||
| """Return the charm application name.""" | ||
| return "cinder-volume-dellpowervault" | ||
|
|
||
| @property | ||
| def charm_channel(self) -> str: | ||
| """Return the default charm channel.""" | ||
| return "latest/edge" | ||
|
|
||
| @property | ||
| def charm_revision(self) -> str | None: | ||
| """Return a pinned charm revision, if any.""" | ||
| return None | ||
|
|
||
| @property | ||
| def charm_base(self) -> str: | ||
| """Return the target base for this charm.""" | ||
| return "ubuntu@24.04" | ||
|
|
||
| @property | ||
| def supports_ha(self) -> bool: | ||
| """Whether this backend supports HA deployments.""" | ||
| return False | ||
|
|
||
| def config_type(self) -> type[StorageBackendConfig]: | ||
| """Return the configuration model type for this backend.""" | ||
| return DellPowerVaultConfig | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
sunbeam-python/tests/unit/sunbeam/storage/backends/test_dellpowervault.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # SPDX-FileCopyrightText: 2026 - Canonical Ltd | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Tests for Dell PowerVault backend.""" | ||
|
|
||
| import pytest | ||
|
|
||
| from sunbeam.storage.backends.dellpowervault.backend import Protocol | ||
| from tests.unit.sunbeam.storage.backends.test_common import BaseBackendTests | ||
|
|
||
|
|
||
| class TestDellPowerVaultBackend(BaseBackendTests): | ||
| """Tests for Dell PowerVault backend.""" | ||
|
|
||
| @pytest.fixture | ||
| def backend(self, dellpowervault_backend): | ||
| """Provide Dell PowerVault backend instance.""" | ||
| return dellpowervault_backend | ||
|
|
||
| def test_backend_type_is_dellpowervault(self, backend): | ||
| """Test that backend type is 'dellpowervault'.""" | ||
| assert backend.backend_type == "dellpowervault" | ||
|
|
||
| def test_display_name_mentions_powervault(self, backend): | ||
| """Test that display name mentions PowerVault.""" | ||
| assert "powervault" in backend.display_name.lower() | ||
|
|
||
| def test_charm_name_is_dellpowervault_charm(self, backend): | ||
| """Test that charm name is cinder-volume-dellpowervault.""" | ||
| assert backend.charm_name == "cinder-volume-dellpowervault" | ||
|
|
||
| def test_dellpowervault_protocol_uses_enum(self, backend): | ||
| """Test protocol field is typed using the Protocol enum.""" | ||
| config_class = backend.config_type() | ||
| protocol_field = config_class.model_fields.get("protocol") | ||
| assert protocol_field is not None | ||
| assert protocol_field.annotation is Protocol |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.