Skip to content

feat: generate ibmibmstorage charm#755

Open
ahmad-can wants to merge 4 commits intocanonical:mainfrom
ahmad-can:feature/generate-ibmibmstorage-charm
Open

feat: generate ibmibmstorage charm#755
ahmad-can wants to merge 4 commits intocanonical:mainfrom
ahmad-can:feature/generate-ibmibmstorage-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Cinder storage backend implementation and accompanying unit tests for an IBMStorage-based charm, integrating it into the existing backend test matrix.

Changes:

  • Introduce IbmibmstorageBackend and IbmibmstorageConfig under sunbeam.storage.backends.ibmibmstorage.
  • Add backend-specific unit tests and hook the new backend into shared backend fixtures and uniqueness checks.
  • Extend common backend tests to include the new backend in parametrized runs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/ibmibmstorage/backend.py New IBMStorage backend + Pydantic config model (including enums/options).
sunbeam-python/sunbeam/storage/backends/ibmibmstorage/__init__.py Package initializer and module docstring for the new backend.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmibmstorage.py New unit tests for backend identity, secrets, and protocol validation.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Extend shared uniqueness/expectation tests to include the new backend.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Add fixtures for the new backend and include it in the any_backend parametrization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/ibmibmstorage/backend.py Outdated
Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmibmstorage.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/ibmibmstorage/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/ibmibmstorage/__init__.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/ibmibmstorage/backend.py
@ahmad-can ahmad-can force-pushed the feature/generate-ibmibmstorage-charm branch from 5aa3f46 to dec8049 Compare April 9, 2026 09:01
@ahmad-can ahmad-can force-pushed the feature/generate-ibmibmstorage-charm branch from fc20dc4 to cec5a43 Compare April 21, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants