feat: generate ibmstorwizesvc charm#756
Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Sunbeam storage backend implementation for IBM Storwize SVC, along with unit tests and fixture wiring so it participates in the shared backend test suite.
Changes:
- Introduce
ibmstorwizesvcbackend module with a Pydantic config model and charm metadata. - Add unit tests validating backend identity, secret-marking of credentials, and protocol validation.
- Extend common backend fixtures/tests to include the new backend in parametrized coverage and uniqueness checks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/backend.py | New backend + config model for IBM Storwize SVC and charm properties |
| sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/init.py | New backend package marker/docstring |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmstorwizesvc.py | New unit tests for the IBM Storwize SVC backend/config validation |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Add ibmstorwizesvc_backend fixture and include it in any_backend |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Include new backend in uniqueness and expected-value parametrized tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ad2fbd2 to
d87d2a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983837