Skip to content

feat: generate ibmstorwizesvc charm#756

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-ibmstorwizesvc-charm
Open

feat: generate ibmstorwizesvc charm#756
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-ibmstorwizesvc-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Sunbeam storage backend implementation for IBM Storwize SVC, along with unit tests and fixture wiring so it participates in the shared backend test suite.

Changes:

  • Introduce ibmstorwizesvc backend module with a Pydantic config model and charm metadata.
  • Add unit tests validating backend identity, secret-marking of credentials, and protocol validation.
  • Extend common backend fixtures/tests to include the new backend in parametrized coverage and uniqueness checks.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/backend.py New backend + config model for IBM Storwize SVC and charm properties
sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/init.py New backend package marker/docstring
sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmstorwizesvc.py New unit tests for the IBM Storwize SVC backend/config validation
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Add ibmstorwizesvc_backend fixture and include it in any_backend
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Include new backend in uniqueness and expected-value parametrized tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/backend.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/ibmstorwizesvc/backend.py Outdated
@ahmad-can ahmad-can force-pushed the feature/generate-ibmstorwizesvc-charm branch from ad2fbd2 to d87d2a8 Compare April 21, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants