Skip to content

feat: generate infinate charm#757

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-infinidat-charm
Open

feat: generate infinate charm#757
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-infinidat-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new INFINIDAT (InfiniBox) storage backend to the Sunbeam storage subsystem, along with unit test coverage and fixture wiring to include it in the existing backend test matrix.

Changes:

  • Implement InfinidatBackend and InfinidatConfig (including protocol enum + secret-marked SAN credentials).
  • Add INFINIDAT-specific unit tests and config validation tests.
  • Extend shared backend test fixtures and “unique backend type/charm name” assertions to include INFINIDAT.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/infinidat/backend.py New INFINIDAT backend + Pydantic config model and charm metadata defaults.
sunbeam-python/sunbeam/storage/backends/infinidat/init.py Introduces the INFINIDAT backend package.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_infinidat.py Adds backend contract tests + protocol validation tests for INFINIDAT.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds an infinidat_backend fixture and includes it in the parametrized backend fixture.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Updates shared tests to include INFINIDAT in uniqueness and expectation matrices.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/infinidat/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/infinidat/backend.py Outdated
@ahmad-can ahmad-can force-pushed the feature/generate-infinidat-charm branch from b578f3c to 72ecc99 Compare April 21, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants