feat: generate inspurinstorage charm#759
Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Sunbeam storage backend implementation and unit tests for the Inspur InStorage charm integration.
Changes:
- Introduces
InspurinstorageBackendandInspurinstorageConfig(including protocol and SAN credential handling). - Adds unit tests for the new backend and integrates it into shared backend test fixtures/expectations.
- Updates common backend tests to include the new backend in uniqueness and expected-values checks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py |
New backend + config model for Inspur InStorage (protocol + SAN config fields). |
sunbeam-python/sunbeam/storage/backends/inspurinstorage/__init__.py |
Declares the new backend package. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_inspurinstorage.py |
New unit tests for the Inspur backend config/validation and secrets metadata. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds an inspurinstorage_backend fixture and includes it in the parametrized backend fixture. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extends shared tests to include Inspur backend type/charm expectations and uniqueness checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
10f31cc to
41fc0ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983853