Skip to content

feat: generate inspurinstorage charm#759

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-inspurinstorage-charm
Open

feat: generate inspurinstorage charm#759
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-inspurinstorage-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Sunbeam storage backend implementation and unit tests for the Inspur InStorage charm integration.

Changes:

  • Introduces InspurinstorageBackend and InspurinstorageConfig (including protocol and SAN credential handling).
  • Adds unit tests for the new backend and integrates it into shared backend test fixtures/expectations.
  • Updates common backend tests to include the new backend in uniqueness and expected-values checks.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py New backend + config model for Inspur InStorage (protocol + SAN config fields).
sunbeam-python/sunbeam/storage/backends/inspurinstorage/__init__.py Declares the new backend package.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_inspurinstorage.py New unit tests for the Inspur backend config/validation and secrets metadata.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds an inspurinstorage_backend fixture and includes it in the parametrized backend fixture.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Extends shared tests to include Inspur backend type/charm expectations and uniqueness checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py
Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_inspurinstorage.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/inspurinstorage/backend.py
@ahmad-can ahmad-can force-pushed the feature/generate-inspurinstorage-charm branch from 10f31cc to 41fc0ae Compare April 21, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants