Skip to content

feat: generate kaminario charm#760

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-kaminario-charm
Open

feat: generate kaminario charm#760
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-kaminario-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Kaminario storage backend implementation to Sunbeam’s storage backend framework and integrates it into the existing unit test suite to ensure consistent backend behavior and config validation.

Changes:

  • Introduce KaminarioBackend and KaminarioConfig under sunbeam.storage.backends.kaminario.
  • Add Kaminario-specific unit tests (backend identity + protocol validation).
  • Update shared backend test fixtures and common backend assertions to include Kaminario.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/kaminario/backend.py Implements the new Kaminario backend and its Pydantic config model.
sunbeam-python/sunbeam/storage/backends/kaminario/init.py Adds the Kaminario backend package initializer.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_kaminario.py Adds unit tests for Kaminario backend identity and config validation.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Extends common backend uniqueness/expectation tests to include Kaminario.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds a kaminario_backend fixture and includes it in the parametrized backend fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_kaminario.py Outdated
@ahmad-can ahmad-can force-pushed the feature/generate-kaminario-charm branch from 9e8d5cc to c82febd Compare April 21, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants