Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Kaminario storage backend implementation to Sunbeam’s storage backend framework and integrates it into the existing unit test suite to ensure consistent backend behavior and config validation.
Changes:
- Introduce
KaminarioBackendandKaminarioConfigundersunbeam.storage.backends.kaminario. - Add Kaminario-specific unit tests (backend identity + protocol validation).
- Update shared backend test fixtures and common backend assertions to include Kaminario.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/kaminario/backend.py | Implements the new Kaminario backend and its Pydantic config model. |
| sunbeam-python/sunbeam/storage/backends/kaminario/init.py | Adds the Kaminario backend package initializer. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_kaminario.py | Adds unit tests for Kaminario backend identity and config validation. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Extends common backend uniqueness/expectation tests to include Kaminario. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds a kaminario_backend fixture and includes it in the parametrized backend fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9e8d5cc to
c82febd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983854