Skip to content

feat: generate necv charm#763

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-necv-charm
Open

feat: generate necv charm#763
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-necv-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new NEC V (“necv”) Cinder storage backend to Sunbeam and integrates it into the existing backend test suite and fixtures.

Changes:

  • Introduce NecvBackend and NecvConfig under sunbeam.storage.backends.necv.
  • Add NECV-specific unit tests and extend common backend tests to include the new backend.
  • Extend test fixtures to provide necv_backend and include it in the parametrized any_backend fixture.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/necv/backend.py Implements the NECV backend and its Pydantic config model.
sunbeam-python/sunbeam/storage/backends/necv/__init__.py Adds the NECV backend package marker/docstring.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds a necv_backend fixture and includes NECV in any_backend.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Updates backend uniqueness/expectation tests to include NECV.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_necv.py Adds unit tests specific to the NECV backend/config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/necv/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/necv/backend.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/necv/backend.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/necv/backend.py
@ahmad-can ahmad-can force-pushed the feature/generate-necv-charm branch from 97a073e to 5c17ae1 Compare April 21, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants