Skip to content

feat: generate opene charm#766

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-opene-charm
Open

feat: generate opene charm#766
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-opene-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 14, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new “opene” storage backend implementation (Open-E JovianDSS iSCSI) to Sunbeam, along with unit tests and wiring it into the existing backend test suite/fixtures.

Changes:

  • Introduce OpeneBackend and OpeneConfig under sunbeam.storage.backends.opene.
  • Add unit tests for the new backend and include it in the shared backend uniqueness/parameterized tests.
  • Extend backend test fixtures to provide an opene_backend and include it in any_backend parametrization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/opene/backend.py Adds the Open-E backend class and its Pydantic config model.
sunbeam-python/sunbeam/storage/backends/opene/__init__.py Declares the new backend package.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_opene.py New unit tests for Open-E backend behavior and config validation.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Extends common backend uniqueness/expectation tests to include opene.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds an opene_backend fixture and includes it in any_backend.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/opene/backend.py
Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_opene.py Outdated
Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_opene.py
@ahmad-can ahmad-can force-pushed the feature/generate-opene-charm branch from 8c6436f to bebbb7d Compare April 21, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants