Skip to content

feat: generate zadara charm#775

Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-zadara-charm
Open

feat: generate zadara charm#775
ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can:feature/generate-zadara-charm

Conversation

@ahmad-can
Copy link
Copy Markdown

@ahmad-can ahmad-can commented Apr 14, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial support for a Zadara storage backend in Sunbeam by introducing a new backend implementation plus unit tests and fixture wiring so the backend participates in the shared backend test suite.

Changes:

  • Introduce ZadaraBackend and ZadaraConfig under sunbeam.storage.backends.zadara.
  • Add a new unit test module for the Zadara backend/config validation.
  • Extend backend test fixtures and common “all backends” assertions to include Zadara.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/zadara/backend.py New backend + pydantic config model for ZadaraVPSA iSCSI.
sunbeam-python/sunbeam/storage/backends/zadara/__init__.py Declares the new backend package.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_zadara.py Adds Zadara-specific tests (type/charm name, secret marking, protocol validation).
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py Includes Zadara in shared uniqueness/expectations tests.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds zadara_backend fixture and includes it in any_backend parametrization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/zadara/backend.py
Comment thread sunbeam-python/tests/unit/sunbeam/storage/backends/test_zadara.py Outdated
@ahmad-can ahmad-can force-pushed the feature/generate-zadara-charm branch from eb80464 to fcbd8c1 Compare April 21, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants