feat: bind k8s cluster endpoint to internal space #786
Open
gboutry wants to merge 2 commits intocanonical:mainfrom
Open
feat: bind k8s cluster endpoint to internal space #786gboutry wants to merge 2 commits intocanonical:mainfrom
gboutry wants to merge 2 commits intocanonical:mainfrom
Conversation
CiliumNodeConfig is a CRD and rejects strategic merge patch. Use JSON merge patch when clearing the restart-pending annotation after a Cilium restart. Assisted-By: Codex (gpt-5.5) Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
Move the k8s charm's cluster endpoint from the management space to the internal space so inter-node communication uses the internal network. Closes-Bug: #2144916 Assisted-By: Codex (gpt-5) Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
hemanthnakkina
previously approved these changes
Apr 25, 2026
gboutry
dismissed
hemanthnakkina’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the k8s charm's cluster endpoint from the management space to the internal space so inter-node communication uses the internal network.
Closes-Bug: #2144916
Re-introduce 4627372 without the annotation management. Now, this is managed by CiliumNodeConfig.