-
Notifications
You must be signed in to change notification settings - Fork 501
Updated initial batch of links for review #5921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Namrathabp <142517234+Namrathabp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Namrathabp Thank you so much for putting this together!
The scope for the PR was originally for CLI commands, so I've left some suggestions clarifying which links shouldn't be changed.
Also, any of the links to dashboard.snapcraft.io and api.snapcraft.io should be left as-is, as a new site for the SnapD site is coming in the new year.
Any of the interface pages on snapcraft.io should remain the same, because SnapD is responsible for them, not Snapcraft.
|
Hi @medubelko, thanks for the guidance! I have reverted the changes to the interface pages and dashboard links as requested. I've also resolved the conversation threads above. The PR is now ready for a re-review when you have a moment! |
For canonical/open-documentation-academy#303.
I have started updating the old snapcraft.io/docs links to the new documentation.ubuntu.com structure.
I need a quick confirmation on my approach: Many specific interface pages (e.g., desktop-interface) do not have a direct equivalent on the new site yet also previously it was common for all files. But in new site, the structure is different. Also, I observed that for few inks, direct interface is not available.
Is this the correct fallback? Once confirmed, I will proceed with updating the remaining files.
make lint && make test.