Skip to content

fix(extensions/gpu): drop XErrorDB layout entry for core26#6205

Merged
mr-cal merged 1 commit intocanonical:mainfrom
bboozzoo:bboozzoo/gpu-2604-no-layout
Apr 23, 2026
Merged

fix(extensions/gpu): drop XErrorDB layout entry for core26#6205
mr-cal merged 1 commit intocanonical:mainfrom
bboozzoo:bboozzoo/gpu-2604-no-layout

Conversation

@bboozzoo
Copy link
Copy Markdown
Contributor

@bboozzoo bboozzoo commented Apr 22, 2026

The actual XErrorDB is shipped by core26 now. No need to install one through layouts.

See canonical/core-base#432 for reference.

  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

@bboozzoo bboozzoo requested review from a team, bepri and mr-cal as code owners April 22, 2026 12:59
@bboozzoo bboozzoo changed the title gpu: drop XErrorDB for core26 gpu: drop XErrorDB layout entry for core26 Apr 22, 2026
@bboozzoo bboozzoo force-pushed the bboozzoo/gpu-2604-no-layout branch from d8b46d4 to 90dacf4 Compare April 22, 2026 13:03
Saviq
Saviq approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

mr-cal
mr-cal approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboozzoo
Copy link
Copy Markdown
Contributor Author

bboozzoo commented Apr 23, 2026

FYI the change in core26 has landed.

@bboozzoo
Copy link
Copy Markdown
Contributor Author

bboozzoo commented Apr 23, 2026 

2026-04-22 13:16:50 Error preparing google:ubuntu-24.04-64:tests/spread/core26/python-hello:strict (apr221309-388048) : 
-----
+ snap install core26 --edge
error: cannot install "core26": snap "core26" assumes unsupported features:
       isa-riscv64-rva23 (try to refresh snapd)
-----

looks like snapd from stable which isn't yet aware of the feature?

@mr-cal
Copy link
Copy Markdown
Collaborator

mr-cal commented Apr 23, 2026 

2026-04-22 13:16:50 Error preparing google:ubuntu-24.04-64:tests/spread/core26/python-hello:strict (apr221309-388048) : 
-----
+ snap install core26 --edge
error: cannot install "core26": snap "core26" assumes unsupported features:
       isa-riscv64-rva23 (try to refresh snapd)
-----

looks like snapd from stable which isn't yet aware of the feature?

Correct. The core26 spread tests are installing snapd from latest/beta in #6202.

@bboozzoo
Copy link
Copy Markdown
Contributor Author

bboozzoo commented Apr 23, 2026

@mr-cal can this land or do you want me to update anything?

@bboozzoo bboozzoo changed the title gpu: drop XErrorDB layout entry for core26 fix(extensions/gpu): drop XErrorDB layout entry for core26 Apr 23, 2026
@bboozzoo
fix(extensions/gpu): drop XErrorDB layout entry for core26
51e6879 
The actual XErrorDB is shipped by core26 now. No need to install one
through layouts.

Signed-off-by: Maciek Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo force-pushed the bboozzoo/gpu-2604-no-layout branch from 90dacf4 to 51e6879 Compare April 23, 2026 19:05
@mr-cal
Copy link
Copy Markdown
Collaborator

mr-cal commented Apr 23, 2026

It's ready to land once I get another starcraft review.

@mr-cal mr-cal requested a review from a team April 23, 2026 19:06
@bboozzoo
Copy link
Copy Markdown
Contributor Author

bboozzoo commented Apr 23, 2026 •
edited
Loading

I've tweaked the commit subject line/PR title to match the policy check

@mr-cal mr-cal merged commit d7d5a21 into canonical:main Apr 23, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigarmo tigarmo tigarmo approved these changes

@medubelko medubelko medubelko approved these changes

@mr-cal mr-cal mr-cal approved these changes

@bepri bepri Awaiting requested review from bepri bepri is a code owner

+1 more reviewer

@Saviq Saviq Saviq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bboozzoo @mr-cal @Saviq @tigarmo @medubelko