Skip to content

boot: set EFI boot variables on install#13025

Closed
olivercalder wants to merge 2 commits intocanonical:masterfrom
olivercalder:set-efi-boot-variables-on-install
Closed

boot: set EFI boot variables on install#13025
olivercalder wants to merge 2 commits intocanonical:masterfrom
olivercalder:set-efi-boot-variables-on-install

Conversation

@olivercalder
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Fixed bugs (notably, now compare `varDevicePathStr` to `devicePathStr`
instead of `EfiShimFilePath`, which would never have matched), and no
longer delete EFI variables which point to a path which matches
`EfiShimFilePath` on a non-matching disk.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #13025 (d61421e) into master (af2f1d9) will increase coverage by 0.09%.
Report is 179 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #13025      +/-   ##
==========================================
+ Coverage   78.69%   78.79%   +0.09%     
==========================================
  Files        1001     1013      +12     
  Lines      124325   126006    +1681     
==========================================
+ Hits        97835    99281    +1446     
- Misses      20334    20524     +190     
- Partials     6156     6201      +45     
Flag Coverage Δ
unittests 78.79% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
boot/makebootable.go 56.75% <0.00%> (-13.47%) ⬇️

... and 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olivercalder
Copy link
Copy Markdown
Member Author

Closing in favor of #13205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants