tests: enable some nested tests by setting up proper kernel declarations on UC26#16452
Merged
ernestl merged 4 commits intocanonical:masterfrom Feb 2, 2026
Merged
Conversation
Member
Author
|
My first commit is also addressed by #16447. Whichever gets merged first will need to address this. |
andrewphelpsj
requested review from
alfonsosanchezbeato and
ernestl
and removed request for
Copilot
andrewphelpsj
force-pushed
the
kmod-component-spread-fix
branch
from
01e4b52 to
45d0e0b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables nested tests for Ubuntu Core 26 by setting up proper kernel declarations and working around a pc-kernel bug in 26/edge that contains duplicate kernel modules.
Changes:
- Enabled Ubuntu 26 systems for kernel component and remodel tests
- Added kernel snap declaration extras for UC26+ driver library slots
- Modified kernel repacking script to handle duplicate modules in pc-kernel
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/nested/manual/remodel-with-components/task.yaml | Enables test for ubuntu-26 and adds conditional kernel declaration extras |
| tests/nested/manual/remodel-with-components-offline/task.yaml | Removes ubuntu-26 exclusion and adds conditional kernel declaration extras |
| tests/nested/manual/kernel-modules-components/task.yaml | Removes ubuntu-26 exclusion to enable test |
| tests/lib/tools/build_kernel_with_comps.sh | Narrows module search to avoid duplicates and adds conditional symlink creation |
| tests/lib/nested.sh | Adds automatic kernel declaration extras for UC26+ kernels in fakestore |
| tests/lib/assertions/pc-kernel-26-snap-decl-extras.json | Defines snap declaration extras for driver library slots |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Mon Feb 2 14:30:04 UTC 2026 Failures:Preparing:
Executing:
|
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
Thanks for this - maybe we should make adding the slots the default for pc-kernel. Note that this declaration is now used even for pc-kernel in UC16, for instance, so actually it would make the tests closer to reality.
Member
There was a problem hiding this comment.
Maybe worth including also nvidia-video-driver-libs, they will eventually use it and it is harmless to put it now in our declaration.
Member
Author
There was a problem hiding this comment.
Did this, and made it the default when repacking a kernel.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16452 +/- ##
==========================================
- Coverage 77.58% 77.57% -0.02%
==========================================
Files 1337 1339 +2
Lines 184908 184876 -32
Branches 2444 2444
==========================================
- Hits 143465 143415 -50
- Misses 32781 32803 +22
+ Partials 8662 8658 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewphelpsj
force-pushed
the
kmod-component-spread-fix
branch
from
c3d8d1a to
a00261f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrewphelpsj
added
the
Auto rerun spread
ernestl
approved these changes
Feb 2, 2026
| @@ -39,15 +39,19 @@ description: kernel component for testing purposes | |||
| EOF | |||
| # Replace _ or - with [_-], as it can be any of these | |||
| glob_mod_name=$(printf '%s' "$mod_name" | sed -r 's/[-_]/[-_]/g') | |||
| module_path=$(find kernel -name "${glob_mod_name}.ko*") | |||
| # TODO: search only in kernel/modules to avoid duplicates (pc-kernel in | |||
Member
There was a problem hiding this comment.
Welcome to replace my previous workaround with this.
Member
|
Failure analysis: |
ernestl
force-pushed
the
kmod-component-spread-fix
branch
from
a00261f to
69cb522
Compare
Merged
ernestl
pushed a commit
to ernestl/snapd
that referenced
this pull request
Feb 3, 2026
…ons on UC26 (canonical#16452) * t/l/t/build_kernel_with_comps.sh: work around bug in current pc-kernel on 26/edge * tests: enable some nested tests by setting up proper kernel declaration on uc26 * tests: always add extra driver lib decls when repacking kernel * t/l/prepare.sh: change destination of systemd dropins for core26
ernestl
pushed a commit
that referenced
this pull request
Feb 9, 2026
…ons on UC26 (#16452) * t/l/t/build_kernel_with_comps.sh: work around bug in current pc-kernel on 26/edge * tests: enable some nested tests by setting up proper kernel declaration on uc26 * tests: always add extra driver lib decls when repacking kernel * t/l/prepare.sh: change destination of systemd dropins for core26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, work around a bug in pc-kernel in 26/edge, which contains duplicate kernel modules, breaking some of our repacking scripts.