Rename charm artifact inline when rename.sh is missing#377
Open
xtrusia wants to merge 1 commit intocanonical:mainfrom
Open
Rename charm artifact inline when rename.sh is missing#377xtrusia wants to merge 1 commit intocanonical:mainfrom
xtrusia wants to merge 1 commit intocanonical:mainfrom
Conversation
Some charm repos no longer ship a rename.sh helper, so the build step
leaves the artifact named ${charm}_${arch}.charm. The test phase and
bundle references expect the canonical ${charm}.charm. Do the rename
inline after build (local or --remote-build) when rename.sh is absent,
mirroring what rename.sh would have done.
Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some charm repos no longer ship a rename.sh helper(although it is in master (in progress), I think it's test suite's responsibility), so the build step leaves the artifact named ${charm}_${arch}.charm.
The test phase and bundle references expect the canonical ${charm}.charm.
Do the rename inline after build (local or --remote-build) when rename.sh is absent, mirroring what rename.sh would have done.
e.g https://review.opendev.org/c/openstack/charm-heat/+/985457