Skip to content

Certtf 756 display number of jobs#853

Merged
ajzobro merged 20 commits intomainfrom
CERTTF-756-display-number-of-jobs
Jan 12, 2026
Merged

Certtf 756 display number of jobs#853
ajzobro merged 20 commits intomainfrom
CERTTF-756-display-number-of-jobs

Conversation

@ajzobro
Copy link
Copy Markdown
Collaborator

@ajzobro ajzobro commented Dec 18, 2025

Description

Converted the list of queues displayed on the agent detail page into a table (matching the format of the queue_detail page exactly).

image

Resolved issues

Resolves CERTF-756.

Documentation

No documentation changes required for web interface change.

Web service API changes

N/A

Tests

Updated server/devel/create_sample_data.py to allow for a random number of queues to be attributed to each agent for better testing.

@ajzobro ajzobro mentioned this pull request Dec 18, 2025
…port of adding more human readable YAML output format for displaying job counts, and included documentation for the various uses of the agent-status command.
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.79%. Comparing base (d9c5bcd) to head (2ba519c).
⚠️ Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   66.75%   66.79%   +0.04%     
==========================================
  Files         103      103              
  Lines        8394     8405      +11     
  Branches      768      770       +2     
==========================================
+ Hits         5603     5614      +11     
  Misses       2650     2650              
  Partials      141      141              
Flag Coverage Δ *Carryforward flag
agent 72.85% <ø> (ø) Carriedforward from d9c5bcd
cli 82.09% <ø> (ø) Carriedforward from d9c5bcd
device 51.11% <ø> (ø) Carriedforward from d9c5bcd
server 87.79% <100.00%> (+0.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
Agent 72.85% <ø> (ø)
CLI 82.09% <ø> (ø)
Common ∅ <ø> (∅)
Device Connectors 51.11% <ø> (ø)
Server 87.79% <100.00%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread cli/testflinger_cli/__init__.py Outdated
Copy link
Copy Markdown
Contributor

@rene-oromtz rene-oromtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!
I just reviewed an added some comment, personally, I think we should skip the modifications in the CLI as this would be a breaking change.

I think the visual aid in the UI is useful but if we were to get the number or jobs in the queue, we already have queue_status which could be scripted with the queues from agent_status.

Also, thanks for adding the docs! I think we also should create a separate issue to document more properly the CLI...

Comment thread cli/testflinger_cli/__init__.py
Comment thread cli/testflinger_cli/__init__.py Outdated
Comment thread cli/testflinger_cli/__init__.py Outdated
Comment thread docs/how-to/view-agent-status.rst Outdated
Comment thread server/src/testflinger/api/v1.py Outdated
Comment thread cli/testflinger_cli/client.py Outdated
Comment thread cli/testflinger_cli/__init__.py Outdated
@ajzobro
Copy link
Copy Markdown
Collaborator Author

ajzobro commented Jan 5, 2026

this would be a breaking change.

I looked at it this way: if looping over a "list" and now looping over a "dictionary" the new keys will be the same as the former values would have been.

I could add another argument to include the number of waiting jobs, but that is inconsistent with providing all the data.

The yaml format is much more human readable out of the box, and there was already yaml support for other commands, I merely expanded upon it.

Another option is to support the number of jobs in the yaml format, and skip the json format.

I find it strange that we feed in yaml files but then spit out json.

@ajzobro ajzobro force-pushed the CERTTF-756-display-number-of-jobs branch from 6125eb2 to 651ba81 Compare January 5, 2026 21:33
Co-authored-by: rene-oromtz <157750458+rene-oromtz@users.noreply.github.com>
Comment thread server/src/testflinger/api/v1.py Outdated
@rene-oromtz rene-oromtz self-requested a review January 6, 2026 17:26
rene-oromtz
rene-oromtz previously approved these changes Jan 6, 2026
Copy link
Copy Markdown
Contributor

@rene-oromtz rene-oromtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@rene-oromtz
Copy link
Copy Markdown
Contributor

rene-oromtz commented Jan 7, 2026

@ajzobro can you please take a look at the failing CI. There is a long line that needs to be addressed before approving/merging

I rerun the other CI run since it was failing due to the bug described in #864 but it should pass in your next commit

@ajzobro ajzobro merged commit ac5afc4 into main Jan 12, 2026
15 of 16 checks passed
@ajzobro ajzobro deleted the CERTTF-756-display-number-of-jobs branch January 12, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants