Skip to content

Add pipewire to the models#81

Open
sergio-costas wants to merge 2 commits intocanonical:mainfrom
sergio-costas:use-pipewire-snap
Open

Add pipewire to the models#81
sergio-costas wants to merge 2 commits intocanonical:mainfrom
sergio-costas:use-pipewire-snap

Conversation

@sergio-costas
Copy link
Copy Markdown
Contributor

@sergio-costas sergio-costas commented Jan 30, 2025

This patch adds pipewire to the JSONs, but still require them to be signed by canonical to generate the final .model files. Along with canonical/core-base-desktop#74 should allow to use pipewire snap in core desktop directly.

Comment thread ubuntu-core-desktop-24-amd64.json
@sergio-costas sergio-costas force-pushed the use-pipewire-snap branch 2 times, most recently from d1272cc to a2bc0e0 Compare January 31, 2025 09:41
Copy link
Copy Markdown
Contributor

@jhenstridge jhenstridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spun up a VM with the updated dangerous model, and updating core24-desktop and ubuntu-desktop-session to the edge channel.

All the interfaces connected as expected, with audio-playback connecting for newly installed snaps. I was not able to play audio though.

I got things to work once I manually connected the pipewire:hardware-observe, and pipewire:system-observe plugs. We had these connecting on ubuntu-desktop-session via the gadget snap, but it is probably better to handle the permissions via the snap-declaration from the store.

I thought pipewire:alsa might be necessary, but things seem to work fine without it.

@jhenstridge
Copy link
Copy Markdown
Contributor

I've made a request for the additional auto-connections here:

https://forum.snapcraft.io/t/request-auto-connection-of-various-interfaces-for-the-pipewire-snap/45545?u=jamesh

With that in place, I think this will be ready to merge and roll out to stable.

This patch adds pipewire to the JSONs, but still require them
to be signed by canonical to generate the final .model files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants