Improve documentation related to the remodelling process.#260
Merged
degville merged 6 commits intocanonical:mainfrom Sep 17, 2025
Merged
Improve documentation related to the remodelling process.#260degville merged 6 commits intocanonical:mainfrom
degville merged 6 commits intocanonical:mainfrom
Conversation
Signed-off-by: Nicolas Harnois <nicolas.harnois@canonical.com>
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
Thanks for this, I did a pass
Collaborator
dilyn-corner
left a comment
dilyn-corner
left a comment
There was a problem hiding this comment.
Just a couple of comments from me.
Signed-off-by: Nicolas Harnois <nicolas.harnois@canonical.com>
Signed-off-by: Nicolas Harnois <nicolas.harnois@canonical.com>
Meulengracht
approved these changes
Sep 9, 2025
Member
Meulengracht
left a comment
Meulengracht
left a comment
There was a problem hiding this comment.
From a technical perspective this looks good to me, thank you for all these improvements, I think they are really nice
alfonsosanchezbeato
approved these changes
Sep 9, 2025
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
LGTM, small nitpick
Signed-off-by: Nicolas Harnois <nicolas.harnois@canonical.com>
degville
approved these changes
Sep 17, 2025
Contributor
degville
left a comment
degville
left a comment
There was a problem hiding this comment.
This is an absolutely fantastic update. Thank you so much @nicoharnois, and also @dilyn-corner and @alfonsosanchezbeato for the feedback. I think it's a huge improvement on what we had before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal note: related to work for https://warthogs.atlassian.net/browse/SNAPDENG-35301