Skip to content

Set gpt partition as bootable if associated to system-boot role#227

Open
upils wants to merge 1 commit intomainfrom
set-gpt-partition-bootable
Open

Set gpt partition as bootable if associated to system-boot role#227
upils wants to merge 1 commit intomainfrom
set-gpt-partition-bootable

Conversation

@upils
Copy link
Copy Markdown
Collaborator

@upils upils commented May 23, 2024

Make sure gpt partitions associated to a system-boot role have the bootable attribute set. This was missing and was problematic because uboot failed to find the partition to boot on.

Fixes FR-8056

@upils upils self-assigned this May 23, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (bb3a3fe) to head (4358120).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          18       18           
  Lines        3429     3431    +2     
=======================================
+ Hits         3222     3224    +2     
  Misses        133      133           
  Partials       74       74           
Flag Coverage Δ
unittests 93.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upils upils requested a review from sil2100 June 18, 2024 12:25
@upils upils force-pushed the set-gpt-partition-bootable branch from 4689e4d to 64ef73a Compare June 18, 2024 12:29
Copy link
Copy Markdown
Contributor

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this. Since it was an actual issue, do you think we could have a test case for it? Checking if the partition attribute is set in expected bootable partition cases?

@upils
Copy link
Copy Markdown
Collaborator Author

upils commented Jun 18, 2024

+1 on this. Since it was an actual issue, do you think we could have a test case for it? Checking if the partition attribute is set in expected bootable partition cases?

And NOW I remember what was missing on this PR! :D I did some manual tests but you are right, I can surely write a test for that, or at least add a check on one of our "full run" tests.

@upils upils force-pushed the set-gpt-partition-bootable branch from 64ef73a to 5b85d23 Compare July 16, 2024 12:08
@upils upils force-pushed the set-gpt-partition-bootable branch 2 times, most recently from 546e6ab to 4358120 Compare October 17, 2024 09:47
Signed-off-by: Paul Mars <paul.mars@canonical.com>
@upils upils force-pushed the set-gpt-partition-bootable branch from 4358120 to 942b272 Compare March 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants