Set gpt partition as bootable if associated to system-boot role#227
Set gpt partition as bootable if associated to system-boot role#227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 18 18
Lines 3429 3431 +2
=======================================
+ Hits 3222 3224 +2
Misses 133 133
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4689e4d to
64ef73a
Compare
sil2100
left a comment
There was a problem hiding this comment.
+1 on this. Since it was an actual issue, do you think we could have a test case for it? Checking if the partition attribute is set in expected bootable partition cases?
And NOW I remember what was missing on this PR! :D I did some manual tests but you are right, I can surely write a test for that, or at least add a check on one of our "full run" tests. |
64ef73a to
5b85d23
Compare
546e6ab to
4358120
Compare
Signed-off-by: Paul Mars <paul.mars@canonical.com>
4358120 to
942b272
Compare
Make sure gpt partitions associated to a system-boot role have the bootable attribute set. This was missing and was problematic because uboot failed to find the partition to boot on.
Fixes FR-8056