Fix build components with legacy sources.list#260
Open
lool wants to merge 1 commit intocanonical:mainfrom
Open
Fix build components with legacy sources.list#260lool wants to merge 1 commit intocanonical:mainfrom
lool wants to merge 1 commit intocanonical:mainfrom
Conversation
During build, the Rootfs definitions should be used for APT sources, while the Customization definitions should be used in the final image. For the legacy APT sources generation, we only followed this logic for the pocket value, not for components. This might also make sense for mirror, but that's not a standalone Customization option.
upils
force-pushed
the
use-rootfs-components-during-build
branch
from
2b8c4f4 to
86b5b44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During build, the Rootfs definitions should be used for APT sources, while the Customization definitions should be used in the final image. For the legacy APT sources generation, we only followed this logic for the pocket value, not for components.
This might also make sense for mirror, but that's not a standalone Customization option.