[DPE-9751] add K8s services for primary and replica endpoints#46
Merged
[DPE-9751] add K8s services for primary and replica endpoints#46
Conversation
Contributor
Mehdi-Bendriss
left a comment
There was a problem hiding this comment.
Thanks René! Really clean, only 1 comment from my side
# Conflicts: # charmcraft.yaml
skourta
reviewed
Apr 23, 2026
Contributor
skourta
left a comment
There was a problem hiding this comment.
Small comments. Thank you @reneradoi
Mehdi-Bendriss
approved these changes
Apr 23, 2026
Contributor
Mehdi-Bendriss
left a comment
There was a problem hiding this comment.
Thanks René! approved, merge pending CI pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Kubernetes services for primary and replica endpoints, which can be used by clients to connect to Valkey.
Design:
K8sClient, that provides methods for creating/updating K8s services and for adding labels to podsreconcile_k8s_services()to the Sentinel manager class that calls the K8s client methods, based on the current deployment and primary/replica setupreconcile_k8s_services()on the leader unit on any peer relation change, to update the ports if requiredOther changes:
1.94.0to allow buildinglightkubeIntegration testing is covered by the existing tests for client relations. The requirer-charms will now connect via the services in the tests on K8s.