fix(terminal): reduce WebGL context pool to leave headroom for Chromium limit#3358
Merged
gregpriday merged 1 commit intodevelopfrom Mar 16, 2026
Merged
Conversation
…um limit - Lower MAX_CONTEXTS from 16 to 12, reserving 4 slots within Chromium's 16-context-per-renderer-process hard cap - Add comment explaining the limit, headroom rationale, and that browser/dev-preview panels are process-isolated via webview partitions
Collaborator
Author
|
Review status: Ready |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalWebGLManager.MAX_CONTEXTSfrom 16 to 12, leaving 4 slots free for any non-terminal WebGL consumers sharing the renderer processwebglcontextlosteviction on a terminal<webview>partitions with their own budgets (so the reservation is conservative headroom for future renderer-resident consumers)Resolves #3277
Changes
src/services/terminal/TerminalWebGLManager.ts:MAX_CONTEXTS16 → 12, with explanatory commentTesting
All existing WebGL lifecycle unit tests pass. The change is a single constant reduction with no behavioral impact on the eviction/fallback path.