feat: add color coding for failed and broken commands#472
Open
cbandera wants to merge 4 commits intocantino:masterfrom
Open
feat: add color coding for failed and broken commands#472cbandera wants to merge 4 commits intocantino:masterfrom
cbandera wants to merge 4 commits intocantino:masterfrom
Conversation
4561c19 to
198f1f6
Compare
Author
|
The diff has gotten somewhat polluted due to my refactoring and attempt to reduce code duplication. |
- Add support for different colors for recently failed commands (non-zero exit code) - Add support for different colors for broken commands (exit_factor == 0.0) - Update configuration to support new color settings in both light and dark modes The changes maintain backward compatibility while adding visual distinction between successful, recently failed, and always-failing commands.
…educes code complexity and duplication)
198f1f6 to
ba8cccf
Compare
Owner
|
Cool, thanks @cbandera! Do you mind running fmt and clippy on this? |
Owner
|
I really like this improvement, thank you! Can you please document it in the README. And, do you think we should add a flag to disable it? Maybe unnecessary, but someone will probably ask... |
Author
|
@cantino I updated the docs and added a flag for deactivation (do you agree with naming?). However during testing I have identified a few edge cases:
So given that I wonder whether I should:
Let me know what you think and I can make the necessary changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #351:
The changes maintain backward compatibility while adding visual distinction between successful, recently failed, and always-failing commands.