fix(landlock): derive paths from wildcard-op policy rules + add MAKE_SOCK#209
Merged
fix(landlock): derive paths from wildcard-op policy rules + add MAKE_SOCK#209
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s + add MAKE_SOCK DeriveReadPathsFromPolicy and DeriveWritePathsFromPolicy silently dropped file_rules that used operations: ["*"] (the wildcard). This meant policy rules like allow-tmp, allow-workspace, and allow-package-caches never fed their paths into the Landlock ruleset, causing "Permission denied" for any filesystem access outside the workspace mount (e.g., Electron apps binding Unix sockets in /tmp). Additionally, the write access mask was missing MAKE_SOCK, so even paths in the write list couldn't have Unix domain sockets created in them — only the workspace could. Fixes: #190 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeriveReadPathsFromPolicyandDeriveWritePathsFromPolicysilently dropped policy rules usingoperations: ["*"]. This meantallow-tmp,allow-package-caches, and similar rules never fed their paths into the Landlock ruleset — causingPermission deniedfor any filesystem access outside the workspace mount.LANDLOCK_ACCESS_FS_MAKE_SOCK, blocking Unix domain socket creation (e.g.,bind()in/tmp) even when the path was explicitly allowed.Fixes #190 —
agentsh wrap -- emdash(Electron) fails withPermission deniedon/tmp/scoped_dir.../SingletonSocket.Test plan
TestDeriveReadPaths_WildcardOps— verifies/tmpderived fromoperations: ["*"]TestDeriveWritePaths_WildcardOps— same for write derivationTestRulesetBuilder_WriteAccessMask_IncludesMakeSock— verifiesMAKE_SOCKbit presentgo test ./...)GOOS=windows go build ./...)agentsh wrap(needs reporter confirmation)🤖 Generated with Claude Code