This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Draft
Conversation
Contributor
|
@kapper-cap looks good. Obviously there are some loose ends, like we want the contract address for Chainlink to be dynamic. Marking as draft. You can keep working on this branch. We can merge when all changes are done. |
kappacappa
reviewed
Dec 19, 2022
| try { | ||
| let priceHistory = await getChainlinkPriceHistory( | ||
| // "0x3607e46698d218b3a5cae44bf381475c0a5e2ca7" | ||
| "0x942d00008d658dbb40745bbec89a93c253f9b882" |
Contributor
There was a problem hiding this comment.
Referring to this in my main thread comment.
Collaborator
Author
There was a problem hiding this comment.
Referring to this in my main thread comment.
I left that static because I thought I would take a look at that when I created the Markets components - when the user would be able to change the market. We'll definitely store this in a better way.
Contributor
|
@kapper-cap good to see new changes. This is a draft but will keep an eye out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetched data from Chainlink and displayed in a line chart