refactor(templates): migrate user.is_staff to user.is_staff_user (#176)#180
Open
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Open
refactor(templates): migrate user.is_staff to user.is_staff_user (#176)#180b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Conversation
…on-ticket templates (captainpragmatic#176) - dashboard.html: 15 instances migrated (highest-traffic page) - billing_list.html, billing_list_component.html: 4 instances total - proforma_detail.html: internal notes guard - base.html: compound user.is_staff or user.staff_role pattern replaced - mobile_header.html: same compound pattern - header_action.html: request.user compound pattern - users/profile.html: 1 instance Ticket templates (detail, list, comments_list, status_and_comments, tickets_table) are excluded — they are covered by PR captainpragmatic#159. Addresses captainpragmatic#176. Signed-off-by: Ciprian Radulescu <craps2003@gmail.com>
Contributor
Author
|
@mostlyvirtual CI green — 24 template instances across dashboard, billing, base, components, and customer templates migrated to is_staff_user. Ticket templates excluded (covered by PR #159). Ready for review 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates ~24 instances of
user.is_staffanduser.is_staff or user.staff_roletouser.is_staff_useracross 8 non-ticket template files.user.is_staff or user.staff_rolesimplified touser.is_staff_userrequest.user.is_staff or request.user.staff_rolesimplifiedNot included
Ticket templates (
detail.html,list.html,comments_list.html,status_and_comments.html,tickets_table.html) are covered by PR #159 and excluded to avoid merge conflicts.Test plan
Addresses #176
🤖 Generated with Claude Code
Closes #176