Open
Conversation
Owner
|
Closing pull request due to inactivity |
capythulhu
reviewed
Jul 30, 2022
main.go
Outdated
| exten := filepath.Ext(os.Args[1]) | ||
|
|
||
| if exten != ".bf" { | ||
| panic("Format not accept! " + exten) |
Owner
There was a problem hiding this comment.
Please, change this message to fit Go error messages pattern. Instead of indicating the wrong extension, which is clearly visible on the command line, inform the correct one. Also, make it all lower case. It could be something like "provided script must be a .bf file".
main.go
Outdated
| func main() { | ||
| p, err := os.ReadFile(os.Args[1]) | ||
|
|
||
| exten := filepath.Ext(os.Args[1]) |
Owner
There was a problem hiding this comment.
Change this variable name to its shortest known abbreviation, in this case, it would probably be ext.
main.go
Outdated
| func main() { | ||
| p, err := os.ReadFile(os.Args[1]) | ||
|
|
||
| exten := filepath.Ext(os.Args[1]) |
Owner
There was a problem hiding this comment.
File extension verification needs to occur after checking the file itself (line 70). That way, if the user inputs an invalid filepath (like "123"), it will not trigger an extension error, but a filepath error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.