Remove safe option from collection creation tests#11
Open
tfogo wants to merge 1 commit intocarbon-io:masterfrom
tfogo:tf-fix-test-mongo34
Open
Remove safe option from collection creation tests#11tfogo wants to merge 1 commit intocarbon-io:masterfrom tfogo:tf-fix-test-mongo34
tfogo wants to merge 1 commit intocarbon-io:masterfrom
tfogo:tf-fix-test-mongo34
Conversation
tfogo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safewas deprecated a while ago. Sending it to MongoDB as an option was no problem for versions <3.4 because it simply wasn't used and the server didn't care. But using this option will throw errors for MongoDB server 3.4 due to new stricter validation of options: https://docs.mongodb.com/manual/release-notes/3.4-compatibility/#stricter-validation-of-index-specifications