refactor: align HTTP status codes with error classification#686
Open
Sotatek-DucPhung wants to merge 1 commit intodevelopfrom
Open
refactor: align HTTP status codes with error classification#686Sotatek-DucPhung wants to merge 1 commit intodevelopfrom
Sotatek-DucPhung wants to merge 1 commit intodevelopfrom
Conversation
Contributor
💥 Preprod Tests: DEPLOYMENT FAILEDTests run against preprod network with live blockchain data |
| "code": 4039, | ||
| "message": "Provided address has wrong casing, this might lead to problems with other tools", | ||
| "retriable": false | ||
| "retriable": true |
Collaborator
There was a problem hiding this comment.
there are errors here:
retriable = true -> HTTP 5xx category of errors
retriable = false -> HTTP 4xx category of errors
Collaborator
There was a problem hiding this comment.
also retriable must stay in the rosetta response, we cannot change this, contract mus be the same, this PR should only affect HTTP status code (integer) that's it.
Map retriable=true → HTTP 500, retriable=false → HTTP 400 instead of returning HTTP 500 for all errors.
Sotatek-DucPhung
force-pushed
the
feat/refactor-http-5xx-and-4xx
branch
from
9d74f04 to
f7c8666
Compare
Contributor
💥 Preprod Tests: DEPLOYMENT FAILEDTests run against preprod network with live blockchain data |
Contributor
❌ Preprod Tests: FAILEDTests run against preprod network with live blockchain data |
Sotatek-DucPhung
changed the title
matiwinnetou
approved these changes
Feb 12, 2026
Contributor
❌ Preprod Tests: FAILEDTests run against preprod network with live blockchain data |
1 similar comment
Contributor
❌ Preprod Tests: FAILEDTests run against preprod network with live blockchain data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#684
Derive HTTP status and retriable flag from error code range:
This removes ad-hoc retriable booleans from ExceptionFactory methods and makes retry behavior predictable for integrators.