Change interfaces to use Realm[Resource]Identifier types#4428
Draft
backspace wants to merge 2 commits into@cardstack/base-no-registerCardReferencePrefix-cs-10745from
Draft
Change interfaces to use Realm[Resource]Identifier types#4428backspace wants to merge 2 commits into@cardstack/base-no-registerCardReferencePrefix-cs-10745from
backspace wants to merge 2 commits into@cardstack/base-no-registerCardReferencePrefix-cs-10745from
Conversation
Change ResolvedCodeRef.module from string to RealmResourceIdentifier, Saved/Unsaved types to RealmResourceIdentifier, and realmURL fields to RealmIdentifier. This is the interface-only change that starts the type cascade — downstream TypeScript errors guide the migration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
@cardstack/base-rris-everywhere-cs-10750
branch
from
5b10868 to
6147a6e
Compare
Add RealmResourceIdentifier casts at boundary points where strings enter the branded type system: constants, code ref construction, document loading, file def mappings, index writing, realm operations, and query engine results. No logic changes — only type annotations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
@cardstack/base-rris-everywhere-cs-10750
branch
from
6147a6e to
62c1a4e
Compare
Host Test Results 1 files ±0 1 suites ±0 2h 7m 53s ⏱️ - 18m 32s For more details on these errors, see this check. Results for commit 62c1a4e. ± Comparison against base commit f03b021. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.