Closed
Conversation
habdelra
requested review from
FadhlanR,
IanCal,
backspace,
burieberry,
ef4,
jurgenwerk,
lukemelia,
richardhjtan and
tintinthong
…re text-decoration shorthand (which can vary across browsers) and instead assert the specific textDecorationLine and textDecorationColor values using getComputedStyle. Added explicit existence checks before reading computed styles so the test fails loudly if expected elements go missing. Adjusted the negative expectation to ensure the non-addon component isn’t styled with underline rgb(0, 0, 0). With these changes the test now captures the intent (“underline in black”) while avoiding brittle string comparisons.
…css-while-indexing
Contributor
Author
|
actually hold off on this--i'm seeing issues with the card grid overlay and the prerendered HTML with <style> elements in it not working... |
Contributor
Author
|
taking a different approach in consumer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bug that came out of the headless chrome work. during teardown glimmer would throw
NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.