Fallback support#36
Open
pixilcode wants to merge 13 commits intoproj/rust-rewritefrom
Open
Conversation
Mainly copied from the original Oneil
Contributor
|
I guess I reviewed this at the same time as the other since that builds on this. Comments there are applicable here as well. |
…make it clear that Oneil does not support timeouts
Contributor
|
Once the CI checks are fixed, this looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the fallback operator (
?) to Oneil, allowing users to define fallback equations when Python functions throw an error.Caching is not completed yet. That will come in a seperate PR. We might as well get this part out there for use since it's done, though.