Remove obsolete flash operations/util #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattalvarado
approved these changes
Jan 7, 2025
Collaborator
|
@dougbalish1 lets put up a PR to see what removing the old flash ops on the channel looks like. For older units, folks can always use older versions of LibMutliSense |
Contributor
Author
|
@mattalvarado I already had some of the flashOp removals on this branch on my machine and it's not too bad finished up, so I pushed here. Happy to split into 2 PR if you prefer though. Thanks! |
Collaborator
|
@dougbalish1 can you just delete the operations from the channel but keep the wire messages? Not that there is a super great reason behind that, but I have tried to keep preserve the full set of wire messages, even the ones that are deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#159 is now merged, and the flashOps have been obsolete on the camera side since ~2020. This removes the old flashutil/update script to prevent user confusion.
@mattalvarado I would also like to remove all of the flashOps code, but not sure if anyone would like it kept back for compatibility with very old units. Let me know what you think