Skip to content

Reworks unused display var to set visibility class #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whazap wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reworks unused display var to set visibility class #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/share-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,8 @@ class ShareButton extends ShareUtils {
_detectNetworks() {
// Update network-specific configuration with global configurations
for (let network of Object.keys(this.config.networks)) {
let display;
let displayClass = 'disabled';

for (let option of Object.keys(this.config.networks[network])) {
if (this.config.networks[network][option] === null) {
this.config.networks[network][option] = this.config[option];
Expand All @@ -738,13 +739,11 @@ class ShareButton extends ShareUtils {

// Check for enabled networks and display them
if (this.config.networks[network].enabled) {
this.class = 'enabled';
displayClass = 'enabled';
this.config.enabledNetworks += 1;
}
else
this.class = 'disabled';

this.config.networks[network].class = this.class;
this.config.networks[network].class = displayClass;
}
}

Expand Down