Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Jan 13, 2026

No description provided.

@tuler tuler requested a review from endersonmaia January 13, 2026 15:11
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026

🦋 Changeset detected

Latest commit: a3f87cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cartesi/sdk Patch
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 90.56% 288 / 318
🔵 Statements 90.15% 293 / 325
🔵 Functions 91.22% 52 / 57
🔵 Branches 74.17% 112 / 151
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 89.2% 77.22% 94.11% 89.01% 66-67, 218, 226, 236, 256, 269, 279, 282, 292, 333, 344-348, 360, 544, 566-571
Generated in workflow #758 for commit a3f87cc by the Vitest Coverage Report Action

@tuler tuler force-pushed the feature/chain-id-31337 branch from 6b5e745 to d334234 Compare January 13, 2026 15:13
@tuler tuler force-pushed the feature/cli-chain-id branch from c2d3094 to 1c14d6b Compare January 13, 2026 15:14
Base automatically changed from feature/chain-id-31337 to prerelease/v2-alpha January 13, 2026 17:49
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did some simple testes like cartesi run, send, status, ....

Maybe we could have proper unit/integration tests for this part of the code in the future.

@tuler tuler force-pushed the feature/cli-chain-id branch from 3f5e0bd to a3f87cc Compare January 13, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants