feat: improve error display #2168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add serializeErrorDetails() function to capture all enumerable properties - Handle WASM/Rust errors with non-standard fields like __wbg_ptr - Update StarknetUnexpectedError to show full error details - Make unknown errors expandable with copy functionality - Format error details as readable JSON with proper indentation
broody
force-pushed
the
feat-show-error-details-NuEHR
branch
from
3ca6fc9 to
649a150
Compare
broody
changed the title
- Use unknown instead of any for better type safety - Add type guard to check if error is an object - Add proper type assertions for safe property access
broody
force-pushed
the
feat-show-error-details-NuEHR
branch
from
9060b8b to
85269f1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add WeakSet-based circular reference detection - Replace circular references with '[Circular Reference]' marker - Handle BigInt serialization by converting to string - Add try-catch fallback for any remaining serialization failures - Prevents JSON.stringify errors from breaking error display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced error display with full error details
{"__wbg_ptr":2987000}serializeErrorDetails()utility functionChanges
serializeErrorDetails()function to capture all error object propertiesStarknetUnexpectedErrorcase to show full error detailsTesting
Error displays now show complete information for debugging, including all WASM/Rust error fields.
Note
Enhances ErrorAlert to serialize and show full error details (with copy and default expansion) across unknown and Starknet errors.
ErrorAlert.tsx:serializeErrorDetails(error)to capture enumerable fields, handle circular refs/BigInt, and include standardErrorprops.StarknetUnexpectedError; setisExpandedby default and enablecopyText.serializeErrorDetailswhenmessageis absent and provide copy support.Written by Cursor Bugbot for commit 06ec27e. This will update automatically on new commits. Configure here.