Transition to casacore 3.6.1 #47
Conversation
…d CountedPtr, code now builds against casacore-3.6.1
…triction, replaced PtrHolder with std::unique_ptr
|
It looks like CI failed. Based on the error message, it looks like it tries to compile casarest against the old casacore (and there was an interface change) |
|
@tammojan Do you know how the CI checks have been setup? It looks to me that it tries to build casarest against the old casacore. Perhaps, the image is old? |
…6.1) in an attempt to fix the CI
|
tried to update starting point in docker/gcc.docker and docker/clang.docker to ubuntu-25.04 (which is supposed to have casacore-3.6.1) but it looks like the CI failed even earlier this time |
|
Hi @VoronkovMA , sorry for the late reply! I'm afraid there's no casacore 3.6.1 in an ubuntu release. Since we also do not have a custom binary distribution, I think the best way is to build casacore from scratch (perhaps by using docker files in the casacore repository). |
…ore - still trying to fix CI
2 participants
Minimal changes to get casarest to build under the new 3.6.1 casacore (many more improvements are theoretically possible, if we had more resources to maintain this code). The changes caused by the relocation of some static methods to TableUtil, which were made at the time of casacore-3.5 transition but remained stashed on a branch (because they were incompatible with casacore-3.5), are also included in this PR. Also minor improvements to the cmake file, e.g. to remove C++ standard limitations which are no longer required by the current casacore.