Skip to content

Conversation

@Adam-Hoelscher
Copy link

Functional changes in these files

  • pyproject.toml
  • src/tryangle/ensemble/base.py
  • src/tryangle/metrics/score.py
  • tests/test_ensemble.py
  • tox.ini

These and several other files also have whitespace changes created by black.

Added sparse<0.16 to tox.ini, which has tradeoffs

  • Pro: tests pass
  • Con: since it's not actually in requirements, it doesn't ensure that the PyPI published version will work. Alternatively, we could add this to pyproject.toml and publish to PyPI immediately.

@cbalona cbalona self-requested a review May 23, 2025 08:58
Copy link
Collaborator

@cbalona cbalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adam, thanks very much for the changes. Happy with them. I did have failed tests on py3.13 with chainladder<0.8.20 however. I plan to do a review of the full codebase this year and fix some deepre issues. We can limit python to <3.13 for now until then. I also agree with adding to pypi with the limitation on chainladder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants