Open
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix xorm-adapter to support Casbin v3
Upgrade to Casbin v3
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapter was using Casbin v2 dependencies, causing interface type mismatches when used with Casbin v3 enforcers:
Changes
github.com/casbin/casbin/v2→v3GetPolicy()now returning([][]string, error)in testsThe adapter implementation required no changes - all
persist.Adaptermethods were already present. The issue was purely an import path mismatch between v2 and v3 type systems.Usage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
go.googlesource.com/update-job-proxy /update-job-proxy ut-80144385.c -fmessage-length--source-root ache/go/1.24.12//home/REDACTED/work/xorm-adapter/xorm-adapter -E 1997253/b181/_pkg_.a ctor ache/go/1.24.12/x64/pkg/tool/linux_amd64/vet ache/go/1.24.12/git r/goleveldb/leverev-parse -fno-stack-proteFETCH_HEAD ache/go/1.24.12/x64/pkg/tool/linux_amd64/vet(dns block)/update-job-proxy /update-job-proxy DROP /usr/bin/dirnameextensions.objectformat test -e stitutions_ECC_RootCA_2015.pem dirname /opt/go/bin/test(dns block)xorm.io/update-job-proxy /update-job-proxy ut-80144385.c -fmessage-length--source-root ache/go/1.24.12//home/REDACTED/work/xorm-adapter/xorm-adapter -E 1997253/b181/_pkg_.a ctor ache/go/1.24.12/x64/pkg/tool/linux_amd64/vet ache/go/1.24.12/git r/goleveldb/leverev-parse -fno-stack-proteFETCH_HEAD ache/go/1.24.12/x64/pkg/tool/linux_amd64/vet(dns block)/update-job-proxy /update-job-proxy DROP /usr/bin/dirnameextensions.objectformat test -e stitutions_ECC_RootCA_2015.pem dirname /opt/go/bin/test(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.